Marcus Brinkmann <[EMAIL PROTECTED]> writes:
> 1. When are you supposed to call diskfs_check_readonly, and when are you
> supposed to check the value of diskfs_readonly directly?
You are always supposed to use diskfs_check_readonly. You should do
it before you actually change the disk, but avoid doing it until other
reasons for failure have passed. (In other words, you should endeavor
to call it only when you will actually do a write.)
> 2. What is the purpose of the #define diskfs_readonly 0 in
> libdiskfs/io_seek.c, and does it still serve this purpose? :)
io-seek.c is a hack so that it can use the same little convenience
macro CHANGE_NODE_FIELD as file_chmod etc. Alas, when we changed to
the diskfs_check_readonly we forgot to fix the hack in io-seek.c.
Thomas
