Your message dated Thu, 2 Mar 2000 21:24:48 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#59471: [[EMAIL PROTECTED]: weak assertions in libstore/rdwr.c]
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Mar 2000 21:37:58 +0000
Received: (qmail 32585 invoked from network); 2 Mar 2000 21:37:58 -0000
Received: from sunu450.rz.ruhr-uni-bochum.de (134.147.64.5)
by master.debian.org with SMTP; 2 Mar 2000 21:37:58 -0000
Received: (qmail 11281 invoked from network); 2 Mar 2000 21:37:58 -0000
Received: from dialppp-7-183.rz.ruhr-uni-bochum.de (HELO localhost)
([EMAIL PROTECTED])
by mailhost.rz.ruhr-uni-bochum.de with SMTP; 2 Mar 2000 21:37:58 -0000
Received: from marcus by localhost with local (Exim 3.12 #1 (Debian))
for [EMAIL PROTECTED]
id 12Qd8J-0003rq-00; Thu, 02 Mar 2000 22:27:43 +0100
Date: Thu, 2 Mar 2000 22:27:42 +0100
From: Marcus Brinkmann <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: [[EMAIL PROTECTED]: weak assertions in libstore/rdwr.c]
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.1.4i
Organization: Marcus Brinkmann's Home
Package: hurd
Version: 2000/03/01
An unattended bug reoprt on help-hurd.
Thanks,
Marcus
----- Forwarded message from Kalle Olavi Niemitalo <[EMAIL PROTECTED]> -----
Delivered-To: [EMAIL PROTECTED]
Resent-Date: Wed, 13 Oct 1999 10:52:29 -0400
To: [EMAIL PROTECTED]
Subject: weak assertions in libstore/rdwr.c
X-URL: http://stekt.oulu.fi/~tosi/
From: Kalle Olavi Niemitalo <[EMAIL PROTECTED]>
Date: 13 Oct 1999 20:17:24 +0300
Resent-Message-ID: <"MiOxO1.0.0n4.Rl91u"@mescaline.gnu.org>
Resent-From: [EMAIL PROTECTED]
X-Mailing-List: <[EMAIL PROTECTED]> archive/latest/1122
X-Loop: [EMAIL PROTECTED]
Precedence: list
Resent-Sender: [EMAIL PROTECTED]
X-UIDL: 5864b146d9f60681d5a46299a702fa78
Resent-Bcc:
The assertions in hurd-19991004/libstore/rdwr.c look suspicious:
assert ((len & (block_shift - 1)) == 0); /* in store_write */
assert ((amount & (block_shift - 1)) == 0); /* in store_read */
block_shift is initialized from store->log2_block_size, so it is
the number of bits to be shifted. However the assertions use it
as a bitmask. I believe they should be changed to:
assert ((len & ((1 << block_shift) - 1)) == 0);
assert ((amount & ((1 << block_shift) - 1)) == 0);
if their purpose is to ensure that the bits shifted out in
(len >> block_shift) and (amount >> block_shift) are all clear.
This error doesn't cause the functions to malfunction unless
block_shift == 0, which it probably isn't.
----- End forwarded message -----
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org Check Key server
Marcus Brinkmann GNU http://www.gnu.org for public PGP Key
[EMAIL PROTECTED], [EMAIL PROTECTED] PGP Key ID 36E7CD09
http://homepage.ruhr-uni-bochum.de/Marcus.Brinkmann/ [EMAIL PROTECTED]
---------------------------------------
Received: (at 59471-done) by bugs.debian.org; 3 Mar 2000 02:24:50 +0000
Received: (qmail 8921 invoked from network); 3 Mar 2000 02:24:49 -0000
Received: from r85aap012887.sbo-smr.ma.cable.rcn.com (HELO frob.com) (209.6.192.195)
by master.debian.org with SMTP; 3 Mar 2000 02:24:49 -0000
Received: (from roland@localhost)
by frob.com (8.9.1/8.9.1) id VAA28208;
Thu, 2 Mar 2000 21:24:48 -0500
Date: Thu, 2 Mar 2000 21:24:48 -0500
Message-Id: <[EMAIL PROTECTED]>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <[EMAIL PROTECTED]>
To: Marcus Brinkmann <[EMAIL PROTECTED]>,
[EMAIL PROTECTED]
Subject: Re: Bug#59471: [[EMAIL PROTECTED]: weak assertions in libstore/rdwr.c]
In-Reply-To: Marcus Brinkmann's message of Thu, 2 March 2000 22:27:42 +0100
<[EMAIL PROTECTED]>
Emacs: (setq software-quality (/ 1 number-of-authors))
Please note this change in libstore/ChangeLog:
1999-10-07 Roland McGrath <[EMAIL PROTECTED]>
* rdwr.c (store_read, store_write): Fix asserts in last change.
I'm closing this report.
