URL:
<https://savannah.gnu.org/bugs/?64061>
Summary: pdfpic.tmac uses sed badly and non-portably
Group: GNU roff
Submitter: gbranden
Submitted: Mon 17 Apr 2023 08:33:25 AM UTC
Category: Macro - others/general
Severity: 3 - Normal
Item Group: Incorrect behaviour
Status: In Progress
Privacy: Public
Assigned to: gbranden
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: Mon 17 Apr 2023 08:33:25 AM UTC By: G. Branden Robinson <gbranden>
Affects groff 1.22.4.
pdfpic.tmac has several problems.
1. It unnecessarily uses double backslashes in a single-quoted sed
expression. Since the roff escape character has been changed (to '@'), this
means that the doubled backslashes appear as-is to sed's input, and some seds
don't support this non-standard usage.
2. It uses the sequence '\n' in the replacement part of a sed 's' command.
This is non-standard and undefined on some seds.
3. It wastefully uses grep to filter the output when sed is readily capable
of performing this task itself without the expense of launching a separate
process in the pipeline.
See [https://lists.gnu.org/archive/html/groff/2023-04/msg00149.html recent
discussion on the groff mailing list].
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64061>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
