Hi Reuben, > Updated patch attached. It seemed too simple: all I do is, as you say, > define _GL_USE_DLADDR only if $(LIBDL) is empty, and then use dladdr only > if _GL_USE_DLADDR is set, and we haven't defined either _GL_USE_PROCFS or > _GL_USE_WIN32.
Yup. It's simpler because we don't touch the link dependencies. The patch looks nearly fine. A few small nits, though: > + dladdr (find_shared_library_fullname, &info); Need to check the return value of dladdr. > -Makefile.am: Even if the Makefile.am section of the module description is empty, better keep it. (See modules/TEMPLATE.) > +if test "$LIBDL" = ""; then In Gnulib, we make use of 'test -z' and 'test -n' since they are fully portable. > + AC_DEFINE([_GL_DLADDR_IN_LIBC], 1, [Define to 1 if dladdr is in libc.]) Please indent by 2 spaces, not by 3. Thanks! Bruno
