Hi Bruno, Bruno Haible <[email protected]> writes:
> Collin Funk wrote: > 0001: > + glob_t g; > + int res; > ... > + return !(res == 0); > > If malloc() fails, res is uninitialized, and the return statement is > undefined behaviour. The probability that this happens is low, > but it may produce a compiler warning, and with -Werror this compiler > warning would lead to a wrong configure test result. Suggestion: > > + int res = 0; Right. ./configure shouldn't be run with -Werror, but it seems like many people are used to using it that way. So it is certainly worth fixing. > 0001: > + case $gl_cv_glob_overflows_stack in > + *yes) REPLACE_GLOB=1 ;; > + *) REPLACE_GLOB=0 ;; > + esac > > The indentation style for shell code in the *.m4 files (just like in > gnulib-tool.sh) is 2 spaces, not 4 spaces. Thanks, I am aware. I think I fixed the surrounding indentation but forgot this part. I'll fix those locally. Collin
