Hi Collin,

> This patch removes some misleading text from the xsetenv module
> description.

I disagree with this patch. The module has a dependency to the 'unsetenv'
module, which provides the unsetenv() function.

Either you remove that dependency (and mention it in NEWS, and check
whether the packages that use 'xsetenv', namely coreutils and gettext,
need an update).
Or you revert the description change.

> I noticed that xsetenv calls the following:
> 
>     error (EXIT_FAILURE, 0, _("memory exhausted"));
> 
> Is there a reason we don't just use xalloc_die here? Or can we change it
> to simplify things a bit?

Explanation: xsetenv.c predates the introduction of the xalloc-die module.
Therefore yes, it's OK to change this code to use xalloc_die().

Bruno




Reply via email to