On 2025-09-18 07:56, Alejandro Colomar wrote:
lib/exclude.c:333: : strcmp (pattern, f));
streq could be used here, but it's a judgement call.
This one would be interesting. When I read that one I wasn't sure if
the integer value was important, or if it was only important as a
boolean. I think using streq() there would be an improvement.
I left the strcmp there because it's parallel with the previous line
which uses mbscasecmp, and it's in a context where int is wanted not
bool. If we were to change the strcmp line we should also change the
mbscasecmp line or put in comments or something, so I thought it better
to leave it alone.
