On 04/09/2025 06:20, Collin Funk wrote:
Bruno Haible <[email protected]> writes:
Collin Funk wrote:
256 bytes seems like enough for the foreseeable future.
I agree: that's more than 3x the 72 bytes that it currently needs.
I think it is okay to leave the abort () calls for EVP_DigestFinal_ex
and EVP_DigestUpdate which seem like they should never fail outside of
programmer error. For example, using a NULL pointer argument or calling
them without calling EVP_DigestInit_ex. I rather abort () there than
have a program print uninitialized memory or something like that.
Pushed the patch with your suggestions, and will work on that test later.
Would it be better to call EVP_MD_CTX_init() rather than memset() ?
Or even simpler, remove the explicit init and use EVP_DigestInit()
rather than EVP_DigestInit_ex(), which the docs imply does an implicit
init of the ctx.
cheers,
Padraig.
