Pádraig Brady wrote:
>   # Honor limit anywhere in /proc/self/cgroup hierarchy
>   $ systemd_nested_cgroup=\
> /sys/fs/cgroup/user.slice/user-1001.slice/[email protected]/app.slice/
> 
>   # The number of processors on this system
>   $ src/nproc
>   4
> ...

This is valuable info for future maintenance of this module.

But if someone wants to do these interactive tests 2 or 10 years from now,
they will certainly not look in the git commit message for them. They will
look in the source file itself or in the unit tests.

Therefore, it would be good if this test recipe was added
  - either in lib/nproc.c, at the end in a
      #if TEST
      ...
      #endif
    block,
  - or in a new file tests/test-nproc.c, as comments.

Bruno




Reply via email to