Hi Collin,

> >> Do you want to deal with it, or should I ?
> >
> > I'll take a look later today.
> 
> I pushed the attached patch which fixes it.

That's great! Thanks a lot.

> It is much simpler than I expected since most of the Android code can be
> reused for OpenBSD. I know Bionic uses a lot of BSD stuff, but I assumed
> the stdio implementation was different. I guess I was wrong.

Yes, it's funny that the two necessary type symbols were already present,
and you didn't have to introduce a third one :)

> I tested a testdir of all modules on an OpenBSD snapshot from 2025-07-19
> and on OpenBSD 7.6 which does not have the change. Both passed all
> tests.

That's perfect.

Small nit: The three comments   /* Android & OpenBSD */
hurt my feelings as a mathematician. I know that "&" is colloquially spoken
as "and", but when it's to describe a preprocessor condition, that symbol
feels wrong. Could you please use "|" or "," instead?

Bruno




Reply via email to