Bruno Haible <br...@clisp.org> writes:

> Yes, I saw this warning too, on some platforms. But warnings on non-GNU
> platforms don't bother me enough.

Yep, I think it is nice to silence warnings enabled by default. But no
need to spend a ton of time on it.

>> Any objections to the attached patch?
>
> I prefer to conditionalize the case statements together with the code that
> follows.

Agreed, your patch looks nicer.

> The advantage would be one less #if statement. gcc optimizes this code nicely.
> But clang doesn't: <https://github.com/llvm/llvm-project/issues/147239>
> So, I see nothing better than to add another #if statement.

Interesting, good catch! I would not have even though about
disassembling and checking. :)

Collin

Reply via email to