Hi Collin,
> I've pushed the 2 attached patches fixing a minor bug in your
> strn?casecmp_l implementations from a few months ago.
>
> On systems where Gnulib defines a locale_t, we need to include
> c-strcase.h for the c_strn?casecmp functions, which are used if the
> given locale is the C locale.
>
> This is a warning on the CI because of the GCC version it uses. But it
> becomes an error in GCC 14 [1].
Thanks for the fixes. Can you please tweak them?
- You can include the c-strcase.h unconditionally, because the
condition in the module description does not test GNULIB_defined_locale_t.
This is simpler.
- The header file c-strcase.h is not among the list of headers that are
provided by libc. Therefore better write
#include "c-strcase.h"
rather than
#include <c-strcase.h>
- It's a far stretch to call it a regression ("regr. 2025-02-16"), since
the mistake was made when the lib/strcasecmp_l.c was first added.
Bruno
