Hi Paul, > > + (sizeof (a) / sizeof ((a)[0]) + 0 * _gl_verify_is_array (a)) > > As a minor point, that expression has the wrong type on theoretical (but > standard-conforming) platforms where size_t is narrower than int. I > installed the attached to address this, plus avoid a bit of namespace > pollution.
Please, no, we shouldn't use __SIZE_TYPE__. It is nowhere documented. Any compiler can define it to what it wants, to a token, to a string, to empty or whatever. Even if it's ok now, it may break any time in the future. We shouldn't care much about namespace pollution in Gnulib. Especially not regarding <stddef.h>, which is a prerequisite for so many other .h files. Also, the change of sizeof ((a)[0]) to sizeof *(a) is more of an uglification in my opinion. Parentheses *do* help reading the code. Bruno
