Paul Eggert wrote: > If > not, perhaps the Gnulib code should stop invoking attr_copy_action, as > in practice xattr.conf does not supply useful information to programs > that want to copy ACLs. Something like the following untested patch, say? > > diff --git a/lib/qcopy-acl.c b/lib/qcopy-acl.c > index 282f4b2d2a..e44f4a942e 100644 > --- a/lib/qcopy-acl.c > +++ b/lib/qcopy-acl.c > @@ -52,8 +52,7 @@ is_attr_permissions (const char *name, struct > error_context *\ > ctx) > because at least on CentOS 7, attr_copy_action does not do it. > */ > return strcmp (name, XATTR_NAME_POSIX_ACL_ACCESS) == 0 > || strcmp (name, XATTR_NAME_POSIX_ACL_DEFAULT) == 0 > - || strcmp (name, XATTR_NAME_NFSV4_ACL) == 0 > - || attr_copy_action (name, ctx) == ATTR_ACTION_PERMISSIONS; > + || strcmp (name, XATTR_NAME_NFSV4_ACL) == 0; > } > > #endif /* USE_XATTR */
xattr.conf may also list _additional_ attributes in the future, which we cannot imagine yet. Removing the call to attr_copy_action would mean to make our code less future-proof. Bruno
