Hi Collin, > I prefer just changing this to an *.in.h file and replacing the variable > like you suggest. Could you double check the attached patch before I > push the change?
The patch is technically correct, AFAICS. Except that I would prefer the file to be named fts.in.h instead of fts_.in.h. We have a common naming idiom that the include file names should be the same as the customary ones in Unix. So that applications don't need to use different .h file names when they start using a Gnulib module. For example, there is a system <getopt.h> and a Gnulib <getopt.h>. Here too, we should have a system <fts.h> and a Gnulib <fts.h>. Maybe we'll change that: fts_.h → fts.h. It's not urgent, but better be prepared to remove this irregularity. With the file being named fts.in.h, it feels more regular / consistent with the other Gnulib modules. Bruno
