Paul Eggert wrote:
> As I'm still a bit concerned that glibc reviewers will object to 
> removing the "ifndef __obstack_free" I installed the attached further 
> patch.

Looks good to me. But the CIs will tell whether it really works fine.

> This further patch affects only people not using Gnulib (i.e., 
> they're using glibc) and who have already #define'd __obstack_free to 
> some other name (presumably their own oddball code), in which case we'll 
> now continue to do what glibc currently does.

Ah, ok. Then the existing comment in glibc

/* The default name of the function for freeing a chunk is 'obstack_free',
   but gnulib users can override this by defining '__obstack_free'.  */

was wrong: it's
  1. now gnulib itself (not the gnulib users) which defines __obstack_free,
  2. users of the installed glibc <obstack.h> which may have defined
     __obstack_free, as an undocumented alternative to using
     obstack_specify_allocation.

Bruno




Reply via email to