On Sun, 4 May 2025, Bruno Haible wrote:
> Hi,
>
> Andy Fiddaman wrote:
> > The attached patch adds support for using the POSIX getlocalename_l()
> > function
> > in illumos to avoid having to reach into undocumented/opaque structs.
>
> Thanks for notifying us about this. Yes, the purpose of getlocalename_l() in
> POSIX is to avoid peeking into undocumented structs.
>
> > 2025-05-03 Andy Fiddaman <illu...@fiddaman.net>
> >
> > getlocalename_l-unsafe: Add support for the POSIX 2024 getlocalename_l
> > on illumos to avoid reaching into undocumented structures.
>
> Thanks for the patch. It could well work. Although, part of it is a no-op:
>
> - The change to m4/intl-thread-locale.m4 is redundant because the Autoconf
> macro that is used with getlocalename_l-unsafe.c, namely
> gl_FUNC_GETLOCALENAME_L_UNSAFE in m4/getlocalename_l.m4, already contains
>
> AC_CHECK_FUNCS_ONCE([getlocalename_l])
>
> And an '#undef getlocalename_l' is needed, in order to avoid an endless
> recursion when gnulib's module 'getlocalename_l-simple' is in use.
>
> I was going to test the attached patch, but find that I cannot test it:
> The commit
> https://github.com/illumos/illumos-gate/commit/004345e48064ccd168d15f66eba2031c6090ccee
> is from 2025-04-24.
> - In OmniOS, https://downloads.omnios.org/media/, the latest 'bloody'
> build and the modification time of the empty directory r151054
> both predate the 2025-04-24. So it's unclear to me what you have
> in fact tested. But it is not an environment that I can get hold of.
> - In OpenIndiana, there is a download
> https://dlc.openindiana.org/isos/hipster/test/OI-hipster-gui-20250425.iso
> but it does not contain the function: "nm /lib/libc.so.1" does not list
> the getlocalename_l symbol, and "man getlocalename_l" returns nothing.
>
> Since I don't want to commit an untested patch, I can only queue the
> patch for now, for later testing.
Thanks for taking the time to look at this. OmniOS r151054 is scheduled for
release tomorrow (5th of May) and the media are now available at
https://downloads.omnios.org/media/r151054/
Installing the OpenIndiana ISO and doing a package update via `pkg update -f`
and a reboot should also get things up to date if you'd like to test there.
Please let me know if there's anything I can do to help - I could provide
access to a VM running OmniOS r151054 if that's useful.
Regards,
Andy
