On 03.05.2025 19:08, Bruno Haible wrote:
Hi,

I think the test cases should remove the overflow gid (ideally the
actual value obtained from /proc/sys/fs/overflowgid) from the obtained
list of gids before further processing.

No, I don't think it makes sense to add complexities to this test that
are 1. specific to Linux, and 2. hard to understand (why would anyone
have to understand what an "overflow gid" is, when maintaining a POSIX
test case?).

I may be lacking context on the exact circumstances and purposes of the test cases, but I saw that commit eecd8afd696055cf39ef934208724bfe850c5760 already made similar platform-specific adjustments for macOS, hence my suggestion.

Instead, how about
  a) if you just ignore the test failures — since you know you are
     running them in a very special environment, or
  b) we can mark these 3 tests as expected test failures if you
     provide an identifier to mark them with, and a corresponding
     condition, so that we can extend gnulib/modules/test-xfail.

I am only a relatively new user of guix, so I can't speak for which approach would be preferable from their perspective. I CC'ed Ludovic since he implemented the unprivileged guix daemon approach.

Bruno

Best,
keinflue

Reply via email to