Hi Collin, > > The 'vc-mtime' module that I added in February turns out to be slower than > > expected by users, when they use it on thousands of files under git version > > control. > > I saw this gettext bug report when it was reported and thought the > libgit2 license issue you noticed was fixed.
Yes, <https://github.com/libgit2/libgit2/issues/7050> will not be a blocker any more, once the libgit2 maintainers have done the trivial change(s). > Did this implementation work fast enough while avoiding the library > dependency? Or was there another reason to not use it? libgit2 has a lot of dependencies, see <https://packages.debian.org/bookworm/libgit2-1.5>. Therefore relying on this library needs a good justification, IMO. The way 'vc-mtime' now works is that (for, say, less than 1000 files at once) it makes 3 'git' invocations. In a scenario where the total time is 12 seconds, some of these calls take more than 5 seconds. This indicates that the bottleneck is the git processing itself. (Like when one starts 'gitk' in a checkout of the FreeBSD repository.) Replacing 3 program invocations with library calls would not save more than 0.1 seconds off the 12 seconds. That is not a speedup that would be worth a dependency on libgit2. Bruno
