Bruno Haible <br...@clisp.org> writes:
> When doing such syncs back to glibc, please sync selected patches. Don't
> just copy the entire file, because usually that will not work, due to
> many coding conventions that are different in glibc than in gnulib.
Yes, I noticed many differences between Gnulib's obstack and glibc's
obstack. Some of them are relevant to glibc, and some are not. But it
is too much to review in a single patch.
> Your finding is correct. You cannot just take a patch that I (or any
> Gnulib contributor) contributed under LGPLv3+ and put it in a different
> project under a weaker license, such as LGPLv2+. You need to ask for
> permission.
>
> I hereby give permission to take any patch that I contributed to Gnulib
> and give it to GNU libc under the LGPLv2+ license.
Thanks! I submitted the patch for the clang undefined behavior sanitizer
issue and Paul fixed it to account for your later Oracle cc fix [1].
Using the following command:
$ git log --follow lib/obstack.in.h
It seems you were the only one to update obstack.in.h after the license
change (minus copyright date updates). Could we change the module to
LGPLv2+ then? I think it is best to keep shared files in sync, even if
it has to be done manually.
Collin
[1]
https://inbox.sourceware.org/libc-alpha/87msbyde0o....@gmail.com/T/#m3473c75162a1805387839db135ebc1829fb5f490
