All,

I noticed that some modern version of lcov's genhtml complain:

$ make gen-coverage PACKAGE=libtasn1-filtered
genhtml --output-directory doc/coverage \
        doc/coverage/libtasn1-filtered.info \
        --highlight --frames --legend \
        --title "GNU Libtasn1"
genhtml: ERROR: (deprecated) option '--highlight' has been removed.
        (use "genhtml --ignore-errors deprecated ..." to bypass this error)
make: *** [maint.mk:1739: gen-coverage] Error 2

The attached installed patch fixes this.

/Simon
From 43bf2e8b659b994f1e50a0cbb9d298e5223e4c95 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <si...@josefsson.org>
Date: Fri, 4 Apr 2025 11:49:13 +0200
Subject: [PATCH] maintainer-makefile: Work with modern LCOV versions.

* top/maint.mk (gen-coverage): Don't pass --highlight to genhtml.
---
 ChangeLog    | 5 +++++
 top/maint.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 8dd75cabcb..4b8614cb93 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2025-04-04  Simon Josefsson  <si...@josefsson.org>
+
+	maintainer-makefile: Work with modern LCOV versions.
+	* top/maint.mk (gen-coverage): Don't pass --highlight to genhtml.
+
 2025-04-02  Bruno Haible  <br...@clisp.org>
 
 	crypto/gc: Silence some -Wcalloc-transposed-args warnings.
diff --git a/top/maint.mk b/top/maint.mk
index 4ac59914c8..00775f786f 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1741,7 +1741,7 @@ build-coverage:
 gen-coverage:
 	genhtml --output-directory $(COVERAGE_OUT) \
 		$(COVERAGE_OUT)/$(PACKAGE).info \
-		--highlight --frames --legend \
+		--frames --legend \
 		--title "$(PACKAGE_NAME)"
 
 coverage:
-- 
2.49.0

Attachment: signature.asc
Description: PGP signature

  • [PATCH] maintainer-makefile: Wo... Simon Josefsson via Gnulib discussion list

Reply via email to