Hi Collin, > > The questions is: which ones are useful in this context? > > I've attached a basic patch, but I have not pushed it since I am unsure > how useful it actually is or if I am missing important information.
The code looks good. Just please add comments /* Documentation: <https://learn.microsoft.com/...> */ before each use of a native Windows API. I would like that reviewing this code be easy. It's unlike the POSIX API, for which such annotations are not needed because we have it in memory or in our bookmarks. > From a test run (on Wine, which isn't perfect): > > $ find ~/.wine/dosdevices/ -name '*:' > /home/collin/.wine/dosdevices/c: > /home/collin/.wine/dosdevices/z: > $ ./gltests/test-mountlist.exe > C:\ NTFS > Z:\ NTFS Please add also your new unit test test-mountlist.c. Once you have added these, I can test it a bit on native Windows (not Wine). > I was under the impression that all mount points on windows had drive > letters. That's a good approximation for a first implementation. People who actually use the more exotic features (esp. network volumes) can then give feedback. Bruno