Hi Collin,

> Therefore, I applied the attached patch to vma-iter
> that fixes the test.

Thanks! I verified that it compiles fine (and passes the test) also
on older Haiku from 3 years ago.

> I guess when the original code here was written:
> 
>        if (info.protection & B_READ_AREA)
>          flags |= VMA_PROT_READ | VMA_PROT_EXECUTE;
> 
> the assumption was that readable memory was also executable?
> [1] https://www.haiku-os.org/legacy-docs/bebook/TheKernelKit_Areas.html

Yes, when this book was written (in 2000), the general assumption was
that read and execute access on a memory page are equivalent. W^X came
years later [1].

Bruno

[1] https://en.wikipedia.org/wiki/W%5EX




Reply via email to