Simon Josefsson wrote:
> If the diff is unreadable, the summary is that it just moves around
> things.
> ...
> The problem happens because 'make release' invoke (via GNUmakefile
> '_version' target) autoreconf to re-generate files for the new version
> number.  I believe this step is working fine, and uses the "right" m4
> directory path as specified by configure.ac.  It is bootstrap that is
> using a different m4 path ordering, which I suspect is "incorrect".
> These two different usages is causing the problem.

One may view it differently: 'bootstrap' (or autogen.sh in other packages)
is the official way to build the generated files. 'autoreconf' is not
generally supported by GNU packages: in some packages it may work, in
other packages it does not work (because autogen.sh often contains
more commands, or because of macros like pkg.m4 that autoreconf does
not know how to pull it).

> But there shouldn't be any requirement that the gnulib m4 directory is
> the first, should there?

There is no such requirement.

> What do you think about this change?
> 
> - AUTORECONFFLAGS="--verbose --install --force -I $m4_base $ACLOCAL_FLAGS"
> + AUTORECONFFLAGS="--verbose --install --force $ACLOCAL_FLAGS"

It sounds like 'autoreconf' does a better job at extracting the list of
m4 files from configure.ac that 'bootstrap'. gnulib-tool also has code
for doing this (see gnulib-tool.sh lines 7322..7342).
So: If the extra '-I $m4_base' is not needed, then omit it. But if it is
needed, I would be in favour of adding all necessary -I options here, not
just one of them.

Bruno




Reply via email to