Bruno Haible [2025-01-10 12:58 +0100] wrote:

> Basil L. Contovounesios wrote:
>> Does this imply that writing to a temporary file first is never needed
>> under distdir?
>
> No. It's never needed under $(distdir) *if* the Makefile rule fails when the
> command fails.
[...]
> What is desired, is that "make dist" fails in this situation.
> That is:
>
> gen-ChangeLog:
>         $(AM_V_GEN)if test -e $(srcdir)/.git; then             \
>           LC_ALL=en_US.UTF-8 TZ=UTC0                           \
>             $(top_srcdir)/build-aux/gitlog-to-changelog        \
>               --srcdir=$(srcdir) > $(distdir)/ChangeLog        \
>           || exit 1;                                           \
>         fi

Should 'make dist' also fail when $(srcdir)/.git does not exist (à la
Automake's maintainer/maint.mk)?  Or is that out of scope for this
documentation example?

> 2025-01-10  Bruno Haible  <br...@clisp.org>
>
>       gitlog-to-changelog: Recommend more reliable Makefile rule idiom.

Thanks again,
-- 
Basil

Reply via email to