Thanks for merging Simon. I've fixed a couple of issues with building gzip, marking the functions as static fixes the -Werror=missing-declarations error, and the MAINTAINERCLEANFILES variable isn't set when building gzip so there's an error when using += with it. There's another issue with the way fopen/fprintf work and I can't figure out how to fix it:
/usr/bin/ld: /tmp/cc06ZLWr.o: in function `main': /home/sam/code/gzip/lib/./crc-generate-table.c:139: undefined reference to `rpl_fopen' /usr/bin/ld: /tmp/cc06ZLWr.o: in function `print_copyright_notice': /home/sam/code/gzip/lib/./crc-generate-table.c:103: undefined reference to `rpl_fprintf' /usr/bin/ld: /home/sam/code/gzip/lib/./crc-generate-table.c:104: undefined reference to `rpl_fprintf' /usr/bin/ld: /home/sam/code/gzip/lib/./crc-generate-table.c:106: undefined reference to `rpl_fprintf' /usr/bin/ld: /home/sam/code/gzip/lib/./crc-generate-table.c:107: undefined reference to `rpl_fprintf' /usr/bin/ld: /home/sam/code/gzip/lib/./crc-generate-table.c:109: undefined reference to `rpl_fprintf' /usr/bin/ld: /tmp/cc06ZLWr.o:/home/sam/code/gzip/lib/./crc-generate-table.c:111: more undefined references to `rpl_fprintf' follow I'm assuming it's the way we're building crc-generate-table in the makefile, I've tried different permutations of adding the gnulib fopen/fprintf modules to the commandline but they didn't work, hopefully someone else knows what the fix is here? On Thu, 31 Oct 2024 at 13:18, Simon Josefsson <si...@josefsson.org> wrote: > I merged this now, thank you! > > I added another patch (attached) to make the decision to use the > slice-by-8 implementation a maintainer option rather than something > visible to end-users. That also fixes the ./configure stdout output, > you forgot the corresponding AC_MSG_RESULT to the AC_MSG_CHECKING. I > don't think it makes sense for normal users to be exposed to this fairly > internal implementation choice. The slice-by-8 implementation is now > the default, and maintainers who wish to disable it for projects that > are really low on memory can add gl_DISABLE_CRC_SLICE_BY_8 early on in > configure.ac. Advanced users can disable it with `gl_crc_slice_by_8=no > ./configure' too. I expect this to be exceptionally rare, although I do > have a use-case for this myself so I appreciate this being configurable. > > Can you build gzip with an updated gnulib and compare speed? And run > the self-test suite too, to add some assurance we didn't mess up > anything. > > A next step would be to evaluate if the assembler CRC instructions help > further on some platforms... > > /Simon >
0001-crc-Fix-bugs-when-building-GZIP.patch
Description: Binary data
