Sam Russell wrote:
> > Also, in GNU coding style, when line breaking is needed within
> expressions,
> > we do the line break before the operator, not after the operator. [1]
> > This affects lib/crc.c lines 73..80, 102..103.
>
> Done.
I meant this expression:
crc = crc32_sliceby8_table[0][(local_buf >> 56) & 0xFF] ^
crc32_sliceby8_table[1][(local_buf >> 48) & 0xFF] ^
crc32_sliceby8_table[2][(local_buf >> 40) & 0xFF] ^
crc32_sliceby8_table[3][(local_buf >> 32) & 0xFF] ^
crc32_sliceby8_table[4][(local_buf >> 24) & 0xFF] ^
crc32_sliceby8_table[5][(local_buf >> 16) & 0xFF] ^
crc32_sliceby8_table[6][(local_buf >> 8) & 0xFF] ^
crc32_sliceby8_table[7][local_buf & 0xFF];
which looks more GNU-style like this:
crc = crc32_sliceby8_table[0][(local_buf >> 56) & 0xFF]
^ crc32_sliceby8_table[1][(local_buf >> 48) & 0xFF]
^ crc32_sliceby8_table[2][(local_buf >> 40) & 0xFF]
^ crc32_sliceby8_table[3][(local_buf >> 32) & 0xFF]
^ crc32_sliceby8_table[4][(local_buf >> 24) & 0xFF]
^ crc32_sliceby8_table[5][(local_buf >> 16) & 0xFF]
^ crc32_sliceby8_table[6][(local_buf >> 8) & 0xFF]
^ crc32_sliceby8_table[7][local_buf & 0xFF];
Other than that, it looks fine.
Bruno
