Bruno Haible wrote:
> KO Myung-Hun wrote:
>>>> * lib/wait-process.c (klibc_waitpid) [kLIBC]: New function.
>>>> (waitpid) [kLIBC]: Define it to klibc_waitpid.
>>>
>>> The code looks good, but lacks comments. In the ChangeLog or git commit
>>> entry, please state *what* has changed, not *why* or *how* the code works.
>>> The *why* and *how* belong in comments.
>>
>> How about this?
>
> Thanks. Applied, with one small change: I moved the new code up in the file.
> We try to avoid the style
>
> #include <some.h>
>
> some function definitions
>
> #include <another.h>
>
> some more function definitions
>
> and instead write
>
> #include <some.h>
>
> #include <another.h>
>
> some function definitions
>
> some more function definitions
>
> because experience shows that this style minimizes weird platform-dependent
> bugs.
>
Ok. Thanks a lot!
--
KO Myung-Hun
Korean OS/2 User Community : https://www.os2.kr/
