Collin Funk wrote:
> Bruno, can mbszero be used here instead of duplicating the #if
> conditions? Isn't it achieving the same thing?
> 
> Assuming that it will be inlined and:
> 
>     memset (&mbs, 0, 4);
> 
> performs the same as:
> 
>    mbs.__count = 0;

Right, mbszero() could be used here instead of the 24 lines of code.
But it is meant to be maximally optimized, and Paul wrote in
<https://lists.gnu.org/archive/html/bug-gnulib/2023-07/msg00145.html>:

  "I fixed mbcel to account for the unsafe assumptions you mentioned,
   so mbcel shouldn't need to use mbszero any more."

So, let him decide.

Bruno




Reply via email to