Re: gnulib-tool (Python) bug: "module count-one-bits doesn't exist"

[Collin Funk]

Hi Paul,

On 5/11/24 12:26 PM, Paul Eggert wrote:
> To reproduce it in a Gnulib repository, run these commands:
> 
> git checkout 4de6323d5d20996e51097a90f617cd4404a23eba
> ./gnulib-tool --create-testdir --dir foo -h stdbit
> 
> The failing output is as follows. I get this output on Fedora 40 x86-64.
> 
> gnulib-tool: warning: module count-leading-zeros     doesn't exist
> gnulib-tool: warning: module count-trailing-zeros     doesn't exist
> gnulib-tool: warning: module count-one-bits         doesn't exist

Thanks for the instructions and report. This is because this function
in GLModule:

    def getDependenciesWithConditions(self) -> list[tuple[GLModule, str | 
None]]:
        # Do stuff
        result.append(tuple([self.modulesystem.find(module), condition]))
        # Store in cache
        return result

So here the return type is wrong, since modulesystem.find() returns
None but prints a warning when the module cannot be found.

So the correct return type is:

   list[tuple[GLModule | None, str | None]]

I'll start working on a patch now to filter out unfound modules
(None). Also that function can be cleaned up a bit now that I look at
it.

Collin