Collin Funk wrote: > I've applied the following patch adding a GLFileTable class as > discussed here: > > https://lists.gnu.org/archive/html/bug-gnulib/2024-04/msg00357.html
Thanks! Looks good. > +class GLFileTable: > + '''The GLFileTable class stores file information for the duration of the > + operation being executed.''' > + > + all_files: list[str] > + old_files: list[tuple[str, str]] > + new_files: list[tuple[str, str]] > + added_files: list[str] > + removed_files: list[str] Interesting syntax. This makes the class easier to understand. You're welcome to do the same thing with the other classes (except for GLError.message, which is private to a single method). > This syntax was introduced in Python 3.6 which is okay for our > dependency on Python 3.7. For older versions they can be removed or be > placed in comments [1]. I've gone with it since I imagine there will > be bigger fish to fry by lowering the version dependency. We are not going to lower the version dependency: - No one asked for it in the beta testing process since last week. - Python 3.6 (and even 3.7) is already end-of-life [1]. Bruno [1] https://en.wikipedia.org/wiki/History_of_Python#Table_of_versions
