Hi Collin, > This patch removes the GLModuleTable.__getitem__ function and changes > the dictionary-like indexing of the GLModuleTable objects to normal > function calls.
Makes sense: This dictionary-like indexing makes sense for GLConfig (for reading and parsing the gnulib-cache.m4 file, and for printing the options in gnulib-comp.m4), but not in GLModuleTable. Applied. > I can also see my typos in function names quickly. When I make typos > in keys I have to wait until things break at runtime. :) +1 > Also, now it is easy to see that GLModuleTable.getAvoids() and > GLModuleTable.setAvoids() are not used. I think that it should be fine > to remove them in that case. Then we can make GLModuleTable.avoids a > set since it is only used for membership checks. OK, fine with me: there are no accessors for inc_all_direct_tests and inc_all_indirect_tests either. Bruno
