Hi Collin,

> filter_filelist will join an empty list. In
> GLModule.getAutomakeSnippet_Unconditional we split by the same
> separator which results in a list with an empty string.

... which is then (at least once) converted to a set with an empty string
and back to a list with an empty string. Pretty ugly.

> To fix this I have made the following change to filter_filelist:
> 
> -    result = separator.join(listing)
> +    # Return an empty string if no files were matched, else combine them
> +    # with the given separator.
> +    if listing:
> +        result = separator.join(listing)
> +    else:
> +        result = ''
>      return result

This is much better than the previous code. Thanks! Applied.

Bruno




Reply via email to