Previously, the syntax-check did not check for the pattern at all,
because the list of files was empty.
Bug introduced when adding the rules in commit 53b4bf3018.

* top/maint.mk (sc_readme_link_install): Change the value of the
variable in_vc_files to contain a pattern for the README file.
(sc_readme_link_copying): Likewise.
Previously, the above rules always passed, because the generated
list of files was empty.  Bug introduced when adding the rules
in commit 53b4bf3018.
---
 ChangeLog    | 10 ++++++++++
 top/maint.mk |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3dabcd0c24..39b043775f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2023-09-24  Bernhard Voelker  <m...@bernhard-voelker.de>
+
+       maintainer-makefile: Fix syntax-check rules wrt README.
+       * top/maint.mk (sc_readme_link_install): Change the value of the
+       variable in_vc_files to contain a pattern for the README file.
+       (sc_readme_link_copying): Likewise.
+       Previously, the above rules always passed, because the generated
+       list of files was empty.  Bug introduced when adding the rules
+       in commit 53b4bf3018.
+
 2023-09-22  Bruno Haible  <br...@clisp.org>
 
        striconveh, *vasnprintf, vasnwprintf: Make more virtual-memory friendly.
diff --git a/top/maint.mk b/top/maint.mk
index 1173b64d10..c0dbc4d9eb 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1375,13 +1375,13 @@ sc_unportable_grep_q:
 
 sc_readme_link_install:
        @require='INSTALL'                                      \
-       in_vc_files='$(top_srcdir)/README$$'                    \
+       in_vc_files='^README$$'                                 \
        halt='The README file should refer to INSTALL'          \
          $(_sc_search_regexp)
 
 sc_readme_link_copying:
        @require='COPYING'                                      \
-       in_vc_files='$(top_srcdir)/README$$'                    \
+       in_vc_files='^README$$'                                 \
        halt='The README file should refer to COPYING[.LESSER]' \
          $(_sc_search_regexp)
 
-- 
2.42.0


Reply via email to