The gcc -Wshadow warning option highlights possible maintainability problems.
This one seemed worth fixing:

libtextstyle/lib/term-style-control.c:740:17: warning: declaration of ‘sig’ 
shadows a parameter


2023-06-02  Bruno Haible  <br...@clisp.org>

        term-style-control: Silence -Wshadow warning.
        * lib/term-style-control.c (continuing_signal_handler): Rename
        parameter.

diff --git a/lib/term-style-control.c b/lib/term-style-control.c
index 44074a84ac..18259c827c 100644
--- a/lib/term-style-control.c
+++ b/lib/term-style-control.c
@@ -721,11 +721,11 @@ stopping_signal_handler (int sig)
 /* The signal handler for SIGCONT.
    It is reentrant.  */
 static _GL_ASYNC_SAFE void
-continuing_signal_handler (int sig)
+continuing_signal_handler (int sigcont)
 {
   int saved_errno = errno;
 
-  log_signal_handler_called (sig);
+  log_signal_handler_called (sigcont);
   update_pgrp_status ();
   /* Only do something while some output was interrupted.  */
   if (active_controller != NULL




Reply via email to