Hi Paul, Thanks for this, few comments: - I do not know which code referenced deny ACE for "EVERYONE@". In reality, there should be none as there is no need. But I agree it is probably harmless.
- I would still reference the who strings indirectly, either via macros (i.e. ACE4_WHO_XXXX) or enum using the names in my original code - because that's the way they are defined in Linux kernel, so it's clear what we are referring to the same thing - I still think the best would be to keep the code in lib/acl-internal.c as other (similar) code exists there already. I admit however that I have no clue how to resolve the linker problem, tried various options, did not work. - I also think it would be good we expose the new function in the header file. It might be not be necessary now, but I can well imagine we might want to reuse it somewhere else. Otherwise, I have tested it on various ACL enabled NFSv4 servers (Linux/ Solaris/ Netapp) and it seems to work OK. Thanks, Ondrej -----Original Message----- From: Paul Eggert <egg...@cs.ucla.edu> Sent: sobota 24. prosince 2022 0:32 To: Ondrej Valousek <ondrej.valousek...@renesas.com> Cc: Gnulib bugs <bug-gnulib@gnu.org> Subject: Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux I had some trouble using that patch in GNU Emacs, as emacsclient wouldn't link. I solved this by moving the new function from acl-internal.c to file-has-acl.c and making it static (no reason to pubilsh it that I know of). While doing this I did a more careful review of the code and came up with the attached patch. Some of this is just to use the usual GNU style; hope you don't mind. Ondrej, please give this a try in your environment, as my NFSv4 environment at work doesn't allow ACLs so I can't easily test it. Thanks.
