> On 4/5/22 22:18, arn...@skeeve.com wrote:
> >   dfa.c:1093:27: warning: use of bitwise '&' with boolean operands 
> > [-Wbitwise-instead-of-logical]

Paul Eggert <egg...@cs.ucla.edu> wrote:
> It's valid in C to use bitwise '&' on bool, and doing so here eliminates 
> a conditional branch at the machine level, which can be a win.
>
> How about if you disable -Wbitwise-instead-of-logical instead, since 
> it's a false alarm?

IMHO clear code beats saving a single branch, which is something I
doubt you can even measure on modern systems.  As Knuth said,
"Premature optimization is the root of all evil." I think that
applies here.

I (at least) request that you make the change in dfa.c.

Thanks,

Arnold

Reply via email to