Paul Eggert wrote:
> I installed that patch
> into Gnulib in your name, and updated the Emacs master branch
> accordingly here:
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f05a93e8232e6f56458ac16d733b03e96a63e930
Glad to hear that it worked fine.
> One thing I noticed in that web page is a lot of lines that look like this:
>
> + $(MKDIR_P) '.' && \
>
> Would it be possible to remove those?
These $(MKDIR_P) invocations don't cost much, because
- there are not that many of them (at most 25 per build),
- on most platforms nowadays 'mkdir -p' is used, as opposed to
the slow 'install.sh' script.
It would be possible to replace, in the module descriptions:
$(MKDIR_P) '%reldir%' && \
with
{ test '%reldir%' = '.' || $(MKDIR_P) '%reldir%'; } && \
It's a micro-optimization. A trade-off between execution speed and
readability.
My vote would be to leave it as is.
Bruno
