Re: [PATCH 1/5] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26241]

[Adhemerval Zanella]

On 24/12/2020 19:45, Paul Eggert wrote:
> On 12/24/20 7:16 AM, Adhemerval Zanella wrote:
>> It sync with gnulib version d9c121346 with the following difference
>> require fix a glibc build:
> 
> As I mentioned today on bug-gnulib I installed some changes into Gnulib which 
> are related, and it'd probably be better to sync with the latest version. 
> (Unfortunately I didn't know about your changes, so there was some 
> overlapping work here.)
> 
>> +# define FUNC_REALPATH_WORKS 1
> 
> I don't see why this change is needed, as the only use of that macro is in 
> "#if !FUNC_REALPATH_WORKS || defined _LIBC", which is unaffected by this 
> change since _LIBC is defined.

I am seeing this with gcc 9.2.1:

canonicalize.c:101:6: error: "FUNC_REALPATH_WORKS" is not defined, evaluates to 
0 [-Werror=undef]
  101 | #if !FUNC_REALPATH_WORKS || defined _LIBC

(We build glibc with -Wundef -Werror).