Paul Eggert wrote:
> On 11/15/20 10:01 AM, Tom G. Christensen wrote:
> > Undefined first referenced
> > symbol in file
> > clock_gettime ../gllib/libgnu.a(tempname.o)
> > ld: fatal: symbol referencing errors. No output written to test-getumask
> > collect2: error: ld returned 1 exit status
> > make[3]: *** [test-getumask] Error 1
> >
> > This issue looks to be generic. It fails similarly on CentOS 6.
>
> I fixed this issue by installing the attached. Thanks for reporting it.
Thanks. Fixing the LDFLAGS for the tests fixes the immediate error,
but consumers of Gnulib modules should also know what they should add
in their prog_LDFLAGS. So, here are two patches to update the 'Link'
sections in the module descriptions. It propagates like this:
tempname <-- mkdtemp, mkostemp, mkostemps, mkstemp, mkstemps
<-- supersede
<-- tmpfile <-- tmpfile-safer
<-- getumask
Bruno
2020-11-16 Bruno Haible <br...@clisp.org>
getumask: Document link dependencies.
* modules/getumask (Link): New section.
2020-11-16 Bruno Haible <br...@clisp.org>
Update link dependencies in modules after 2020-09-09 change.
* modules/tempname (Link): Add $(LIB_CLOCK_GETTIME).
* modules/mkdtemp (Link): Likewise.
* modules/mkostemp (Link): Likewise.
* modules/mkostemps (Link): Likewise.
* modules/mkstemp (Link): Likewise.
* modules/mkstemps (Link): Likewise.
* modules/supersede (Link): Likewise.
* modules/tmpfile (Link): Likewise.
* modules/tmpfile-safer (Link): Likewise.
>From 1bb0df49196cc9ffaf5ccd5278a1c3e4387a8eef Mon Sep 17 00:00:00 2001
From: Bruno Haible <br...@clisp.org>
Date: Mon, 16 Nov 2020 16:35:31 +0100
Subject: [PATCH 1/2] Update link dependencies in modules after 2020-09-09
change.
* modules/tempname (Link): Add $(LIB_CLOCK_GETTIME).
* modules/mkdtemp (Link): Likewise.
* modules/mkostemp (Link): Likewise.
* modules/mkostemps (Link): Likewise.
* modules/mkstemp (Link): Likewise.
* modules/mkstemps (Link): Likewise.
* modules/supersede (Link): Likewise.
* modules/tmpfile (Link): Likewise.
* modules/tmpfile-safer (Link): Likewise.
---
ChangeLog | 13 +++++++++++++
modules/mkdtemp | 1 +
modules/mkostemp | 1 +
modules/mkostemps | 1 +
modules/mkstemp | 1 +
modules/mkstemps | 1 +
modules/supersede | 1 +
modules/tempname | 1 +
modules/tmpfile | 1 +
modules/tmpfile-safer | 1 +
10 files changed, 22 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 8c4342f..92a8add 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2020-11-16 Bruno Haible <br...@clisp.org>
+
+ Update link dependencies in modules after 2020-09-09 change.
+ * modules/tempname (Link): Add $(LIB_CLOCK_GETTIME).
+ * modules/mkdtemp (Link): Likewise.
+ * modules/mkostemp (Link): Likewise.
+ * modules/mkostemps (Link): Likewise.
+ * modules/mkstemp (Link): Likewise.
+ * modules/mkstemps (Link): Likewise.
+ * modules/supersede (Link): Likewise.
+ * modules/tmpfile (Link): Likewise.
+ * modules/tmpfile-safer (Link): Likewise.
+
2020-11-15 Paul Eggert <egg...@cs.ucla.edu>
getumask-tests: port to Solaris 10 etc.
diff --git a/modules/mkdtemp b/modules/mkdtemp
index 13b2d5a..d4603bf 100644
--- a/modules/mkdtemp
+++ b/modules/mkdtemp
@@ -25,6 +25,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/mkostemp b/modules/mkostemp
index 460e842..8bfd9d5 100644
--- a/modules/mkostemp
+++ b/modules/mkostemp
@@ -28,6 +28,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/mkostemps b/modules/mkostemps
index bb9fe71..0f67ab4 100644
--- a/modules/mkostemps
+++ b/modules/mkostemps
@@ -27,6 +27,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/mkstemp b/modules/mkstemp
index d985715..ba0ef94 100644
--- a/modules/mkstemp
+++ b/modules/mkstemp
@@ -26,6 +26,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/mkstemps b/modules/mkstemps
index 1e5f097..364cfa8 100644
--- a/modules/mkstemps
+++ b/modules/mkstemps
@@ -26,6 +26,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/supersede b/modules/supersede
index b01ca52..38f52fa 100644
--- a/modules/supersede
+++ b/modules/supersede
@@ -34,6 +34,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
GPL
diff --git a/modules/tempname b/modules/tempname
index 385c65a..27b0d3d 100644
--- a/modules/tempname
+++ b/modules/tempname
@@ -33,6 +33,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPLv2+
diff --git a/modules/tmpfile b/modules/tmpfile
index 20b88c8..fc71e2d 100644
--- a/modules/tmpfile
+++ b/modules/tmpfile
@@ -28,6 +28,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
LGPL
diff --git a/modules/tmpfile-safer b/modules/tmpfile-safer
index 02e49d4..d385cdb 100644
--- a/modules/tmpfile-safer
+++ b/modules/tmpfile-safer
@@ -22,6 +22,7 @@ Include:
Link:
$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
License:
GPL
--
2.7.4
>From f1b7489ca2b67e4c68ab2a8e0591ef42562166e7 Mon Sep 17 00:00:00 2001
From: Bruno Haible <br...@clisp.org>
Date: Mon, 16 Nov 2020 16:37:44 +0100
Subject: [PATCH 2/2] getumask: Document link dependencies.
* modules/getumask (Link): New section.
---
ChangeLog | 5 +++++
modules/getumask | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 92a8add..c0c0466 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2020-11-16 Bruno Haible <br...@clisp.org>
+ getumask: Document link dependencies.
+ * modules/getumask (Link): New section.
+
+2020-11-16 Bruno Haible <br...@clisp.org>
+
Update link dependencies in modules after 2020-09-09 change.
* modules/tempname (Link): Add $(LIB_CLOCK_GETTIME).
* modules/mkdtemp (Link): Likewise.
diff --git a/modules/getumask b/modules/getumask
index f7784da..61d71d0 100644
--- a/modules/getumask
+++ b/modules/getumask
@@ -26,6 +26,10 @@ Makefile.am:
Include:
<sys/stat.h>
+Link:
+$(LIB_GETRANDOM)
+$(LIB_CLOCK_GETTIME)
+
License:
GPL
--
2.7.4
