The module description has three problems:
1) The condition [test $gl_need_lib_has_acl] could give a shell syntax error.
It should be [test -n "$gl_need_lib_has_acl"].
2) lib/file-has-acl.c needs module acl-permissions unconditionally, to get the
acl_errno_valid function (used both when GETXATTR_WITH_POSIX_ACLS and when
!GETXATTR_WITH_POSIX_ACLS).
3) lib/acl-internal.h and m4/acl.m4 are not part of the public interface of
module 'acl-permissions'. Therefore, the module description needs to list these
files explicitly.
2020-03-22 Bruno Haible <br...@clisp.org>
file-has-acl: Fix module description.
* modules/file-has-acl (Files): Add lib/acl-internal.h, m4/acl.m4.
(Depends-on): Depend on acl-permissions unconditionally.
diff --git a/modules/file-has-acl b/modules/file-has-acl
index 7b9b4f5..4857fea 100644
--- a/modules/file-has-acl
+++ b/modules/file-has-acl
@@ -2,10 +2,12 @@ Description:
Whether a file has an ACL.
Files:
+lib/acl-internal.h
lib/file-has-acl.c
+m4/acl.m4
Depends-on:
-acl-permissions [test $gl_need_lib_has_acl]
+acl-permissions
configure.ac:
gl_FILE_HAS_ACL
