On Sun, Mar 17, 2019 at 4:16 PM Paul Eggert <egg...@cs.ucla.edu> wrote: > I installed the attached patch into Gnulib to remove an unnecessary > assignment in fts_safe_changedir. > > Jim, could you please check this? My patch does not change behavior, but > I worry that there's a bug in fts_safe_changedir that the unnecessary > assignment was a symptom of. This is code you wrote many years ago, so ...
Hi Paul, Thank you. I agree it's an unnecessary assignment. I confirmed that it was in the original (to gnulib) version, 7f01591aadb13b59cb04f9ad42400eb7ea1c6e19. Incidentally, that seems like the type of useless assignment a modern compiler could easily warn about.
