sorry, I forgot to include bug-gnulib, sending again ... For reference, the original change in coreutils was published here: https://lists.gnu.org/r/coreutils/2018-10/msg00032.html
On 10/28/18 9:48 AM, Paul Eggert wrote: > @@ -291,7 +269,8 @@ do_link (const char *source, const char *dest, int > link_errno) > if (source_status == 0 > && SAME_INODE (source_stats, dest_stats) > && (source_stats.st_nlink == 1 > - || same_name (source, dest))) > + || same_nameat (AT_FDCWD, source, > + destdir_fd, dest_base))) This change leads leads to a FP syntax-check failure: $ make syntax-check ... prohibit_same_without_use src/ln.c maint.mk: the above files include same.h but don't use it make: *** [maint.mk:575: sc_prohibit_same_without_use] Error 1 The attached gnulib patch fixes the SC rule - pls. check. Thanks & have a nice day, Berny
>From c0ae1232b82d1677a7f30e177204a679088e2009 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker <[email protected]> Date: Sun, 28 Oct 2018 13:06:30 +0100 Subject: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" * top/maint.mk (sc_prohibit_same_without_use): Adjust regex to check for 'same_nameat', too. --- ChangeLog | 6 ++++++ top/maint.mk | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 55493fde2..7299a0da8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2018-10-28 Bernhard Voelker <[email protected]> + + maintainer-makefile: fix syntax-check rule for "same.h" + * top/maint.mk (sc_prohibit_same_without_use): Adjust regex to check + for 'same_nameat', too. + 2018-10-25 Paul Eggert <[email protected]> havelib: fix nested âconfigureâ chatter diff --git a/top/maint.mk b/top/maint.mk index 508c2f7c3..a6270277f 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -572,7 +572,7 @@ sc_prohibit_posixver_without_use: @h='posixver.h' re='\<posix2_version *\(' $(_sc_header_without_use) sc_prohibit_same_without_use: - @h='same.h' re='\<same_name *\(' $(_sc_header_without_use) + @h='same.h' re='\<same_name(|at) *\(' $(_sc_header_without_use) sc_prohibit_hash_pjw_without_use: @h='hash-pjw.h' \ -- 2.19.1
