On 18 August 2018 at 20:45, Bruno Haible <br...@clisp.org> wrote: > Paul Eggert wrote: > > I didn't think the patch would be controversial > > ... whereas I would think that every revert or partial revert is > controversial > (except for obvious typos). > > > Please feel free to > > revert the patch and replace it with something better. > > Done as follows: > - I added a small test module 'scratch_buffer-tests'. It showed the same > errors as reported by Reuben. > - The I inserted '#include <libc-config.h>' in scratch_buffer.h. The > errors > went away. > > Reuben, could you please verify that it fixes the issue with glob.c in your > situation? Thanks. >
This makes the build break again because of the problem I reported in glob_pattern_p.c (see my patch for it).