On Sun, Jun 24, 2018 at 4:20 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 24/06/18 16:10, Jim Meyering wrote: >> +/* Without this pragma, gcc version 9.0.0 20180616 suggests that >> + the canon_* functions might be candidateifor attribute 'malloc' */ >> +#if 9 <= __GNUC__ >> +# pragma GCC diagnostic ignored "-Wsuggest-attribute=malloc" >> +#endif > > typo in candidatefor > > These functions basically wrap strdup() so would seem like > it would be valid to tag them with _GL_ATTRIBUTE_MALLOC ?
Indeed. Thanks! Pushing your suggested fix momentarily.