On 01/01/2018 10:53 AM, Paul Eggert wrote: > Thanks, but -Wunused-parameter issues so many false alarms that I think > I'd rather just ask people to compile with -Wno-unused-parameter. That's > what coreutils does, and Emacs, and so forth.
Can you elaborate on this please? I'm failing to see why this would be a false positive. Despite this function being inlined, compiler might decide to not inline it and thus treat it as any other function in which case the variable is unused indeed. > > By the way, this thread duplicates one of a couple of days ago, starting > here: > > http://lists.gnu.org/archive/html/bug-gnulib/2017-12/msg00077.html Ah, haven't noticed, sorry. > > Is there some new project using Gnulib that is causing these new > messages? If so, perhaps I should propose a patch to it to pacify GCC > without having to pollute the code with void no-op casts. Yes, libvirt. However, libvirt's no newbie to gnulib. We've used it for ages. Michal