On 12/15/2017 03:17 AM, Tim Rühsen wrote:
>>> >>> # define NOWARN_PUSH(a) \ >>> _Pragma( STRINGIFY( clang
diagnostic push ) ) \ >>> _Pragma( STRINGIFY( clang diagnostic ignored a
) )
I would rather not clutter the code with calls to macros like these, as
such calls detract from ordinary development. It's OK to put this stuff
in a place that we ordinarily don't have to look at, but it's not OK to
add needless complexity to code that people need to read to understand
what the code is doing.
It ought to be easy to disable the warnings entirely, for the entire
build, and that is better than to waste peoples' time inserting these
calls and then later having to read them. If it's easy to do disable
warnings on a per-module basis then I guess that's OK too. But it's not
OK to clutter the actual code. We don't have enough resources to waste
them on pacifying compilers that cry wolf so often.
