On Mon, Jan 9, 2017 at 11:58 AM, Paul Eggert <[email protected]> wrote: > Use the spelling "timestamp", as that is what POSIX uses.
Whenever making a global change like this (for which regression is probable), I like to add something to help ensure consistency. We already have a "syntax-check" rule to prohibit things like "can not", so it's easy to add there:
From 94386a13667c645fd42544a7fd302cdddd39fcdf Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Tue, 10 Jan 2017 07:19:02 -0800 Subject: [PATCH] maint.mk: enforce spelling of "timestamp" (i.e., no space) * top/maint.mk (prohibit_undesirable_word_seq_RE_): Also disallow /\btime\s+stamps?\b/. Prefer "timestamp". --- ChangeLog | 6 ++++++ top/maint.mk | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8fda293..1294aec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2017-01-10 Jim Meyering <[email protected]> + + maint.mk: enforce spelling of "timestamp" (i.e., no space) + * top/maint.mk (prohibit_undesirable_word_seq_RE_): Also + disallow /\btime\s+stamps?\b/. Prefer "timestamp". + 2017-01-10 Paul Eggert <[email protected]> dfa: minor simplification with emptyset diff --git a/top/maint.mk b/top/maint.mk index 28cb9db..0cabd2f 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -983,10 +983,11 @@ sc_prohibit_doubled_word: # Also prohibit a prefix matching "\w+ +". # @pxref gets the same see/also treatment and should be parenthesized; # presume it must *not* start a sentence. +# POSIX spells it "timestamp" rather than "time\s+stamp", so we do, too. bad_xref_re_ ?= (?:[\w,:;] +|(?:see|also)\s+)\@xref\{ bad_pxref_re_ ?= (?:[.!?]|(?:see|also))\s+\@pxref\{ prohibit_undesirable_word_seq_RE_ ?= \ - /(?:\bcan\s+not\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims + /(?:\bcan\s+not\b|\btime\s+stamps?\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims prohibit_undesirable_word_seq_ = \ -e 'while ($(prohibit_undesirable_word_seq_RE_))' \ $(perl_filename_lineno_text_) -- 2.8.0-rc2
