On 01/05/2017 04:18 PM, Nelson H. F. Beebe wrote:
> Compilation with native Sun compilers, both on GNU/Linux, and on the
> Solaris family, all die because of erroneous C code in sed-4.3:
>
> CC lib/dfa.o
> "lib/dfa.c", line 1592: warning: statement not reached
> "lib/dfa.c", line 2099: void function cannot return value
> cc: acomp failed for lib/dfa.c
Thanks, fixed in Gnulib with the attached.
From 2d3d408f8c6b46ba62bda43c9f79db1c3240a3cc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 6 Jan 2017 12:49:39 -0800
Subject: [PATCH] dfa: fix 'return' typo
Problem reported by Nelson H. F. Beebe.
* lib/dfa.c (merge): Fix typo that Sun compilers rejected.
---
ChangeLog | 6 ++++++
lib/dfa.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index ebd491f..d3dad04 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-01-06 Paul Eggert <eggert@cs.ucla.edu>
+
+ dfa: fix 'return' typo
+ Problem reported by Nelson H. F. Beebe.
+ * lib/dfa.c (merge): Fix typo that Sun compilers rejected.
+
2017-01-05 Pádraig Brady <P@draigBrady.com>
parse-datetime: fix generated paths for coverage files
diff --git a/lib/dfa.c b/lib/dfa.c
index 4f65665..8276db1 100644
--- a/lib/dfa.c
+++ b/lib/dfa.c
@@ -2086,7 +2086,7 @@ merge_constrained (position_set const *s1, position_set const *s2,
static void
merge (position_set const *s1, position_set const *s2, position_set *m)
{
- return merge_constrained (s1, s2, -1, m);
+ merge_constrained (s1, s2, -1, m);
}
/* Delete a position from a set. Return the nonzero constraint of the
--
2.9.3
