On 12/08/16 04:38, Assaf Gordon wrote: >> On Aug 10, 2016, at 05:59, Pádraig Brady <p...@draigbrady.com> wrote: >> >> Those look good to squash and apply, >> modulo s/setftime/strftime/ in modules/parse-datetime > > Thank you for the review. > Attached a squashed patch. > I kept the name of the new function as 'parse_datetime2' (if that's > acceptable).
There's precedent for .....2() versions of functions, like renameat2() etc. How about we pass an unsigned int flags, instead of bool, in case we ever need to extend in future?
